I do agree with Wez (not 'completely agree', though ;) FWIW, mbstring was/is indeed enabled by default under Windows, and I think that at this stage this is not a good idea. There was at least one serious crash in the code that was introduced by the changes, into both the mbstring version and the non mbstring version of the input handling routines, but I don't really attribute it to mbstring. **** happens. I do think that the large amount of duplicate code in there is not a good idea at all, and it should be refactored into a more generic solution - fixing the same bug twice, once under Windows (because it was in the mbstring code) and once under UNIX (becasue it was also in the non-mbstring code) was not fun at all. I also think that the large amount of mbstring-related MFH's were not a good idea either. Good i18n support is a strategic goal for PHP, and mbstring should be a big step in that direction. But I think that the people here who said that it's something for v5.0 and not v4.x made a good point.
Zeev At 11:52 02/09/2002, Wez Furlong wrote: >Having been using it to handle more than 105,000 email messages over >the last 18 months *in production*, I have to disagree. > >I have to say that I'm appalled that most of the people making these >"I completely agree" comments have probably never even tried to use >mbstring; most certainly haven't even read the bugzilla report and >therefore don't even realize what the problem is. > ><rant to="php-dev"> > If you're going vote on something, *PLEASE* make yourselves > aware of the real issues. > > PHP needs some forward thinkers, and brainlessly agreeing to > disable a module, based on the valid principle of PECL removing > cruft, is not forward thinking. The "noise" has only helped to > obscure the issue even more, because people are all jumping on > the PECL is great bandwagon, when that is *not* the issue here. > It's nice to see that people want to keep PHP clean, but *please* > let's understand what we are voting for before we actually vote. ></rant> > >Now, the mbstr-enc-trans might have had some stability issues, but as >I've been saying, it is NOT enabled by default, and lets print a >warning about it when it is turned on. > >Don't penalize serious developers because of this (already resolved) issue. > >--Wez. > >On 09/02/02, "James Cox" <[EMAIL PROTECTED]> wrote: > > Derick pretty much said it for me... but more explicitly, > > mbstring isn't stable enough to be default. > >Derick wrote: > > > Every respectable sysadm in eastern countries installing PHP should be > > > aware fo this and enable mbstring for his users. > >No, PHP should include encoding support by default - this was already >discussed and decided here on php-dev. (That's why it's enabled by >default in 4.2). > > > > >-- >PHP Development Mailing List <http://www.php.net/> >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
