On Sunday 29 September 2002 21:38, Sascha Schumann wrote: > On Sun, 29 Sep 2002, Edin Kadribasic wrote: > > Hi Sascha, > > > > Without going into the specifics of my implementation of embeddable > > phplib at this point, don't you think the author of the implementation > > should be at least asked for his motivation for doing things in a > > particular way before you just go ahead and change everything? > > Edin, > > I've made it clear during the CLI integration phase that > hacks in the build system don't aid maintainability and > extensibility. They generally should be avoided.
But sometimes they add desired functionality. Like building CLI at the same time as another SAPI module. This "hack" has worked quite well for the past half a year or so and it is generaly considered very stable. At least I have not heard that there were problems with it. > From your emails, it was apparent that you were looking for a > smoother way to integrate your SAPI module into the whole > build process. I've done this work for you now and > transformed the hack into something everyone can work with, > now and a year down the road. Yes I was looking for a way to make "make install" part work in a satisfactory way. You did nothing in that regard. You just made impossible to build a SAPI + CLI + LIB at the same time. In fact you broke "make install" alltogether when compiled with (IMHO unneccessary) --enable-embed option. > Please refer to my earlier email to Derick on how it is > possible to go on from here. Your comments to Derick make very little sense to me. We have a bunch of object files compiled. They are categorized in PHP_GLOBAL_OBJS, PHP_SAPI_OBJS, and PHP_CLI_OBJS. It's only a matter of linking those to get the desired target. I added another class PHP_LIB_OBJS which makes it very easy to have the LIB target by simply linking global and lib objects. But if you consider this change a "hack" and "polution" it is very difficult for me to argue on the technical merit alone. Edin -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
