On Wednesday 23 October 2002 10:55, Yasuo Ohgaki wrote:
> Edin Kadribasic wrote:
> > Ok. Let's agree that the current implementation is not ideal, but it
> > works. There were already several suggestions on how this can be
> > improved, but I don't think this is the right time to start doing it.
> >
> > So my proposal is that Yasuo reverts his patch until 4.3.0 is branched
> > and then let's have a look at how to solve CLI ini/flush issues.
>
> No problem, since the hard coded setting is over written
> by php.ini under almost all UNIX environment.
>
> Before I do, as Murkas pointed out, we are better to check
> how Windows users affected by this. I'll add the setting
> few days later.
>
> (It may be good idea ship pre2 with current code. Comments?)

Since your commit has a potential to break some programs that PEAR depends on, 
I still think that you should revert your patch. And I think that it should 
stay that way for 4.3.0.

If you really want imlicit flush disabled (or any other ini setting for that 
matter) you can always use CLI -d switch.

Edin


--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to