Derick Rethans wrote:
> derick                Thu Oct 31 09:02:00 2002 EDT
> 
>   Modified files:              
>     /php4     Makefile.global run-tests.php 
>   Log:
>   Discuss first!

Huh? What do you mean discuss first?
There is discussion and the patch is valid.

In addition, you're the one insisted certain ini should
not be used.

Let me know how you would like to solve puzzle. For instance,
if users is disabling some functions that are needed by
run-tests.php?

You should have clever idea that I cannot think of ;)

--
Yasuo Ohgaki

>   
>   
> Index: php4/Makefile.global
> diff -u php4/Makefile.global:1.38 php4/Makefile.global:1.39
> --- php4/Makefile.global:1.38 Thu Oct 31 08:52:58 2002
> +++ php4/Makefile.global      Thu Oct 31 09:01:58 2002
> @@ -50,7 +50,7 @@
>       @TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \
>        TEST_PHP_SRCDIR=$(top_srcdir) \
>        CC=$(CC) \
> -                     $(top_builddir)/$(SAPI_CLI_PATH) -d 'open_basedir=' -d 
>'safe_mode=0' -d 'safe_mode=0' -d 'output_buffering=Off' -d 'auto_prepend_file=' -d 
>'auto_append_file=' -d 'output_handler=' -d 'register_argv=1' -d 'disable_functions=' 
>$(top_srcdir)/run-tests.php $(TESTS)
> +                     $(top_builddir)/$(SAPI_CLI_PATH) -d 'open_basedir=' -d 
>'safe_mode=0' $(top_srcdir)/run-tests.php $(TESTS)
>  
>  clean:
>       find . -name \*.lo -o -name \*.o | xargs rm -f
> Index: php4/run-tests.php
> diff -u php4/run-tests.php:1.103 php4/run-tests.php:1.104
> --- php4/run-tests.php:1.103  Thu Oct 31 08:52:58 2002
> +++ php4/run-tests.php        Thu Oct 31 09:01:58 2002
> @@ -44,9 +44,8 @@
>  
>  $cwd = getcwd();
>  set_time_limit(0);
> +ob_implicit_flush();
>  error_reporting(E_ALL);
> -ini_set('magic_quotes_runtime', 0);
> -ini_set('memory_limit', '8M');
>  
>  if (ini_get('safe_mode')) {
>       echo <<< SAFE_MODE_WARNING
> 
> 


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php


Reply via email to