>> Are you sure you should be using malloc()/free() and not >> emalloc()/efree()? Also please use strlcpy() instead of strncpy(). >> (Weird I mentioned it twice in one day :) >> http://www.courtesan.com/todd/papers/strlcpy.html > > Probably there are even more things broken in my patch :) I'm quite new > to C and I'm happy it works without segfaulting. strlcpy looks > interesting and I'll read through the link as soon as I find some free > time. > > Oh, this patch is explicitly *NOT* meant to go into the main branch. > It's just an additional patch for whoever needs it, sorry for not > pointing this out more explicitly. > Good because I havn't seen any positive responses to this and I'm still negative on it.
Apart from disagreement with the prinicipal here I'd also ask: "Where is the portion of the patch to support Win32 SMTP via the MAPI interface?" ((as opposed to sendmail_path interface which you've covered on all platforms)) A more generalized fix would be to append the Return-Path to the headers string at the top of the php_mail function so that it's caught by both the sendmail block and by the TSendMail call (MAPI). Any modification to behavior which effects one platform should affect all platforms equally. While Win32/sendmail is kept equal, Win32/MAPI (used by the majority of Win32 users) is not. -Pollita -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
