I think you (Sascha) need to provide a proper example of how to do it "properly". It's insufficient to just say "Don't do that". At least point to a place in the code where it is done properly. These changes are needed by the developer, and the developer will use them whether they're in the codebase or not (I've been using a custom build of PHP for longer than I can remember because my patches don't seem to be acceptable for inclusion into the php code base). If unacceptable, then direct the willing developer in the proper fashion, I'm sure they'll be happy to receive direction to lighten their load. "Don't spill wine" is not proper direction.
This is also a somewhat hypocritical position since similar changes have been done for Win32 compatibility all over the code base. As far as spilling wine, it won't be the first time, nor the last. Joseph Who'd still like his register_shutdown_function patch approved, or at least some direction on how to do it "properly". > -----Original Message----- > From: Sascha Schumann [mailto:[EMAIL PROTECTED]] > Sent: Friday, January 03, 2003 2:25 PM > Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /sapi/apache2filter > php_apache.h sapi_apache2.c > > I need to say it again. > > These modifications are *extremely* ugly. > > It's like spilling a glass of wine over important documents. > You won't be able to remove the spilled substance without > expensive labor. > > These modifications lack proper factoring. They repeat the > same kind of change all over our code base. Instead of > hiding some of netware's properties behind appropiate > macros and typedefs, you duplicate existing code in a > slightly changed manner all over the place. > > What do you guys think about this? > > - Sascha -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
