On Tue, 28 Jan 2003, Zeev Suraski wrote: > Your latest patch seems to be in the right direction (admittedly I haven't > reviewed it until now). A couple of random points: > > - It sounds dangerous to me to move php_request_shutdown() to be called > from Apache's shutdown without further inspection. At least one thing > comes to mind - won't it screw up output buffers (they're supposed to > autoflush on shutdown, and if I'm not mistaken, this autoflush will now > happen when the connection is already closed)? Possibly some other things too. > - Once we're all happy with the patch, we need to decide what to do with > it. Right now, there are no plans to release any further 4.x versions, > except for bug fixes. And the question arises - should this change be in a > bugfix release or not. It certainly has potential to screw things up.
I don't favor merging this to the PHP_4_3 branch, as it seems a huge change. (And it's broken for quite some time anyway). Derick -- ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ ------------------------------------------------------------------------- -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
