On 8/22/16 00:09, Lukas Kahwe Smith wrote:
-1 from Jackalope
not sure here what to do .. feels a bit like a precedent .. its a clear
omission, yet any fix is a BC break (classic bug fix is kinda always a BC
break). so if we do a BC break, then rather the exception .. if we don’t want
to break BC, we release a new PSR with this fix (since just versioning the PSR
to 6.1 isn’t’ semver for a BC break)?
I think we need to see what current implementations do. From what I
understand reading the code:
* Stash already throws an InvalidArgumentException (467 981 Packagist
installs)
* Symfony already throws an InvalidArgumentException (48 233 Packagist
installs)
* php-cache injects the value without any check (43 786 Packagist installs)
That's for the implementations with the most installations on Packagist.
Having a look at the other implementations, most of them do like php-cache.
So, as most of (2 is probably not significant but Stash has many
installs) the "major" implementations already throws an
InvalidArgumentException, why not just document that in PSR-6? I
understand the BC break and all, but can't we be a bit pragmatic here
(or is it just a classic French/latin way of thinking)?
Fabien
On 19 Aug 2016, at 20:43, Larry Garfield <[email protected]> wrote:
I hereby open a vote for the following Errata for PSR-6:
https://github.com/php-fig/fig-standards/pull/787
Basically, it's a vote to merge that PR.
The vote will be open for 2 weeks, closing on 2 September 2016 @ 23:59 UTC.
As usual, the vote is open to voting representatives only and is a simple +1/-1
vote.
I definitely appreciate the point that an InvalidArgumentException would have
been better, and had this issue been brought up during the Review phase I'd
probably have gone that direction. However, adding an exception does count as
an API change, albeit a small one, so I am not comfortable with that direction
in an Errata. (Obviously if you feel that this is a bad decision, vote -1.)
--Larry Garfield
--
You received this message because you are subscribed to the Google Groups "PHP
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/php-fig/e9508662-70c7-e91a-05ff-82c8dfb59884%40garfieldtech.com.
For more options, visit https://groups.google.com/d/optout.
regards,
Lukas Kahwe Smith
[email protected]
--
You received this message because you are subscribed to the Google Groups "PHP
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/php-fig/d039869b-f515-f0d9-e2d4-89802a533a5d%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
