Please remember to CC the mailinglist. On Tue, Jun 25, 2013 at 1:12 PM, Mike Griffiths <mgriffi...@gmail.com> wrote: > On 25 June 2013 20:57, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: >> >> We don't use any framework no, and won't be using any either. >> > > I guess I didn't phrase that so well; I was more asking whether using MVC > was acceptable or not, not necessarily downloading an off-the-shelf thing, > but more implementing a very basic one ourselves. Not to worry though, I'll > just use includes as it currently is.
Nope. Think "greppable". If you can't easily grep the codebase to find what you need to fix then it won't fly. >> > Secondly, I have noticed that a lot of the information displayed on >> > people.php.net is taken from GitHub and master >> > (https://master.php.net/fetch/user.php?username=mikemike), the latter >> > requiring a token. I guess there are two questions here: Is the >> > 'master' >> > JSON fetch the best way of doing things and can I get access to that >> > file to >> > at least see what it is doing (read-only). it doesn't appear to be on >> > GitHub >> > (https://github.com/php/web-php)? Is GitHub the best place to be >> > fetching >> > the data from? I'm guessing not as most of us don't have GitHub access >> > - >> > perhaps it should just be info added on master.php.net/manage/? >> > >> >> When it was originally created I just pulled info from random 3rd >> party sources for the fun of it, pear, github, olhoho and whatever. >> Didn't see the need to duplicate all the info on master.. But the >> username guessing logic wasn't the best one in the world so I suspect >> much of it has been removed by now. >> >> It would make sense to ask for peoples usernames (on master) on these >> things so we can pull the information about the right people >> correctly. >> >> As for getting the token we currently use, I'd prefer not to hand it >> out. You should be able to get one yourself quite easily. >> > > From what I can tell at the moment it's quite unreliable to assume the same > username across platforms (GitHub, pear, etc). What would you suggest; > adding more information on master, allowing people to amend information on > people (which opens a can of worms as it would need DB access or something > suchlike) or something else? I think personally having a more detailed > account on master is ideal, but I don't want to start this off by making > work for other people. Adding an option to specify your username on these services if fine on master. What sort of other information are you thinking should be added on master? You are doing the work so its prettymuch up to you what you want do implement.. -Hannes -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
