W dniu 2014-03-13 14:37, Hannes Magnusson pisze:
On Wed, Mar 12, 2014 at 11:32 PM, Hannes Magnusson
<[email protected]> wrote:
On Wed, Mar 12, 2014 at 9:45 PM, Maciej Sobaczewski
<[email protected]> wrote:
Hello,
I'm new here, so I hope that I'm posting into proper list. I would like to
ask about the status of news.php.net web interface.
It is quite old and not being updated for a long time and I can see a few
things which could be improved. However, as far as I can see each commit in
last year to repository web-news has been reverted. I mean three commits,
especially big "Rewrite of news.php.net" from KalleZ.
I really would like to help in some way and I think my skills are sufficient
to improve simple bugs etc but you know, I just don't want to do a lot of
job which will be reverted.
So, did Kallez do something wrong or web-news is just frozen and no more
changes are desirable? If it's still possible to send pull requests to this
repo, what were KalleZ's mistakes?
His commit was take-it-or-leave-it type of driver-by commit.
Thats means several things, among:
- Impossible to review
- If it breaks, noone knows why
- Unknown security implications towards internal systems
Which is what actually happened, and why he never bothered to chunk
down his changes.
We require incremental changes so we can verify things. Know when they
break. Understand security concerns and performance implications... :]
We will gladly accept any patches to the system, especially since like
you mentioned it is old and no longer maintained.
I do however suspect your time may be better spent elsewhere as the
underlying nntp server is bound to die at somepoint.. (it was a custom
development that hasn't been active for ~10 years and is very buggy).
A totally new way of approaching it maybe would be interesting.
Something to replace http://www.php.net/mailing-lists.php ?
Just keep the changes incremental, and/or talk about them (on this
list)/mocking them before spending to much time on it :)
Noticing that https://github.com/php/web-news/pull/1 is still open...
If it would have been chunked into multiple prs then its easier to
reaview them. One big one like that is difficult when you don't have
much time to spend :(
I'm sure you can cherry-pick some of his patches?
-Hannes
Sure. Actually I was just writing a reply to this thread. Anyway, thank
you for the exclamation about mentioned commit. As I tought it was too
big and could cause unexpected issues.
-Sobak
---
Ta wiadomość e-mail jest wolna od wirusów i złośliwego oprogramowania, ponieważ
ochrona avast! Antivirus jest aktywna.
http://www.avast.com
--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
