On Thu, Mar 13, 2014 at 8:08 AM, Maciej Sobaczewski <[email protected]> wrote: >> >> Noticing that https://github.com/php/web-news/pull/1 is still open... >> If it would have been chunked into multiple prs then its easier to >> reaview them. One big one like that is difficult when you don't have >> much time to spend :( >> >> I'm sure you can cherry-pick some of his patches? >> >> -Hannes >> > > I did a short review of his pr but... as far as I can see it is almost > nothing to merge. First of all, most of changes which this pr contains were > already introduced in standalone commits. > > Rest of them are: > - moving header and footer into separate files (which I consider not so > important, escpecially if you're saying that this website will be changed > soon)
I didn't mean that there is a current project to change/update/replace news.php.net.. So if this sort of changes makes it easier to maintain/prettify/whatever then its fine. There are no plans, at the moment, to kill or replace news.php.net (frontend or backend). So feel free to develop it further in any direction you feel is right - just make sure its incremental changes :) > project. The only change about which I'm not sure is using new function > split_headers() instead of current code. Maybe someone else can look if it's > really usefull (maybe it fixes some bugs, personally I don't noticed). > > https://github.com/php/web-news/pull/1/files#diff-a42f66146674dc22205431a6b3779b2cR179 > - mentioned function > > https://github.com/php/web-news/pull/1/files#diff-64521afa3dc0748736b4c87b8e1f3168L56 > - context where it's used I have vague memories of attachments sometimes being screwed up.. Would this fix that problem? -Hannes -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
