Hey:

On Fri, Jul 25, 2014 at 12:30 AM, Hannes Magnusson
<[email protected]> wrote:
> This is not how you manage pecl account requests.
>
> What exactly are you looking to do?
> A simple reply to the requests to confirm/decline your involvement in
> them goes a long way.
let me describe why I did it in this way.

a chinese developer srain asked for pecl account recently , I think
it's okey, but for a long time no one actually approval his request.

he reached me via weibo, I don't want to make him think it's slow
(difference in timezone I know)

so I thought if I am the admin of master.php.net , then I can approval
his request.

then I did that,  for the mirro admin, it's really shouldn't happene ,
 I just grep "tyreal"( the current master) in the codes, and append my
id after his, I thought this will work..


but it turns out , no,, I still can not approval his pecl request(he
can use mail, master, but not pecl)

anyway,  I still am willing to help approval the accounts (from
chinese, language different, timezone different), but yeah, I really
thought it in wrong way.

thanks
>
> -Hannes
>
>
> On Wed, Jul 23, 2014 at 7:51 PM, Xinchen Hui <[email protected]> wrote:
>> Commit:    ca3956afbe71a92199922e5cd1cac3b746411fa4
>> Author:    Xinchen Hui <[email protected]>         Thu, 24 Jul 2014 
>> 10:51:21 +0800
>> Parents:   c7935f23dbed2b44ac8b4277da2b9cfa7ceed424
>> Branches:  master
>>
>> Link:       
>> http://git.php.net/?p=web/master.git;a=commitdiff;h=ca3956afbe71a92199922e5cd1cac3b746411fa4
>>
>> Log:
>> I'd like to help reviewing the PECL account request from chinese
>>
>> Changed paths:
>>   M  include/functions.inc
>>   M  manage/mirrors.php
>>
>>
>> Diff:
>> diff --git a/include/functions.inc b/include/functions.inc
>> index be94f66..33ffc71 100644
>> --- a/include/functions.inc
>> +++ b/include/functions.inc
>> @@ -447,6 +447,7 @@ function is_admin($user) {
>>      "felipe",
>>      "johannes",
>>      "tyrael",
>> +    "laruence",
>>    );
>>    return in_array($user, $admins);
>>  }
>> diff --git a/manage/mirrors.php b/manage/mirrors.php
>> index 99aea0f..6d69b3b 100644
>> --- a/manage/mirrors.php
>> +++ b/manage/mirrors.php
>> @@ -677,7 +677,7 @@ function is_mirror_site_admin($user) {
>>              array(
>>                  "jimw", "rasmus", "andrei", "zeev", "andi", "sas", "thies",
>>                  "rubys", "ssb", "imajes", "goba", "derick", "cortesi", 
>> "wez",
>> -                "bjori", "philip", "danbrown", "tyrael",
>> +                "bjori", "philip", "danbrown", "tyrael", "laruence",
>>              )
>>          )
>>      ) {
>>
>>
>> --
>> PHP Webmaster List Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>



-- 
Laruence  Xinchen Hui
http://www.laruence.com/

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to