Gabor Hojtsy wrote:
mmm. not that much. You are right, we don't need a new directory.
I'm thinking about patching mkindex.php to include config.php (with the new BUILD_TYPE constant) and add some IF statements. Does it sound better ?


They are different as mkindex.php is written for phpdoc :

- peardoc needs peardoc/global.ent to be parsed
- $parse_dirs is not the same
- there's not revision.xml file


Here's another patch : http://didou.keliglia.com/build_patch_v2.txt


Would it be possible to create some type of config file, which sets the required values and possibly defines some functions (as with the layout)? Now it might seem to be appropriate to do some exceptions, but then if you try to integrate PHP-GTK or Smarty docs parsing, it will get difficult to patch around.

That's what I did for the first patch (a new directory with mkindex.php and mktoc.php tuned for each build type)..


As we didn't deal with gtk and smarty docs yet, I'd like to see the second patch commited. The config file can be created later (if we really find that we need it)

didou

Reply via email to