On 12 Mar 2004 at 16:50, Gabor Hojtsy wrote: > >> Would it be possible to create some type of config file, which sets > >> the required values and possibly defines some functions (as with > >> the layout)? Now it might seem to be appropriate to do some > >> exceptions, but then if you try to integrate PHP-GTK or Smarty docs > >> parsing, it will get difficult to patch around. > > > > That's what I did for the first patch (a new directory with > > mkindex.php and mktoc.php tuned for each build type).. > > > > As we didn't deal with gtk and smarty docs yet, I'd like to see the > > second patch commited. The config file can be created later (if we > > really find that we need it) > > But duplicating mkindex.php is a damn bad idea, since there are so > simple differences. A bit of abstraction in the build system might > help in this case. > > If PEAR support is needed now, then commit this, and we will see > something later to abstract it out. I still think that if we can > convince you, it would be better to abstract some stuff out now, and > leave some controllers for each project, which define what default > functions, and what project specific functions need to run and in what > order.
Clear abstraction is imho the better choice then incorporating everything with if's etc. But please note that even though phpdoc and peardoc are quite similar there may be other output-formats which need a completely different layout. And we shouldn't try to worry about dublicating a file but mainly think if this might be useful to keep the possibilities far more open. Stefan
