> I reviewed the patches and applied 7 of them, thanks guys. > The Cygwin patch was not applied because I have not way to test it and the > last person I spoke to who build the manual on win32 via Cygwin had no > issues.
Thanks Ilia! The patch about the win build is a tricky issue I've described some time ago (http://marc.theaimsgroup.com/?l=phpdoc&m=108582318626874&w=2). Livedocs builds perfectly on windows, but build the DB with *absolute* paths, while it should use relative, thus breaking the handle_include() function. (read that url for a more complete explanation) As you may see in my old post there are several ways to fix the problem. I had no time yet to extensively debug this problem, but I'm using my patch and it is working well :) I'm going to vacations now, but when I back we can discuss this issue. > Follow, Nuno example :-). He is doing great work, which for the most part gets > into CVS once Wez or I have the time to review it. Thanks :) > There are some critical bugs in the code in particular dealing with > pregeneration logic that fails to create some pages. While it's mostly self > contained inside pregenerate.php there are some spillbacks to other files. > Until that is resolved I'd like to keep once branch only, once that is fixed > we can tag a "stable" release as that's the only major issue I am aware of at > this point. I've also a bug list here, that I'll try to fix when I have some time. I don't think that branching is the right way to go. I prefer posting my patches somewhere with a description and then let someone to review, comment and apply/discard them. Nuno
