When is this slated for production release? On Sep 16, 2012 3:48 AM, "Sherif Ramadan" <theanomaly...@gmail.com> wrote:
> On Sun, Sep 16, 2012 at 3:37 AM, Maciek Sokolewicz > <maciek.sokolew...@gmail.com> wrote: > > On 12-09-2012 03:54, Sherif Ramadan wrote: > >> > >> Just an update I've pushed the new commits to github and fixed a > >> couple of issues in the backend scripts (patch attached here). The > >> javascript for the user notes stuff was moved to a separate file, > >> it'll be better for caching in the UA this way, and removes a lot of > >> the inline code from the PHP. I also fixed some of the CSS issues with > >> the ?beta=1 version of the site. Although the JS is bit quirky there > >> atm. Working on that, but that's really due to the way the CSS is done > >> there. Still needs tweaking (but it's not like we advertise that part > >> as working now anyway). > >> > >> https://github.com/php/web-php/pull/7 > >> > >> If anyone finds any other issues I missed please let me know. > >> > >> Thanks :) > >> > > > > It might not be advertised as working, but it's still used by a lot of > > people (mainly those involved in the PHP Project somehow!) so if you can > > choose not to break it in the first place: just don't break it! ;) > > > > This doesn't break anything in the ?beta version of the site actually. > There are just some unintended UI issues due to the way the CSS > styling is done in the beta site right now and that conflicts with my > existing code. It's not that it doesn't work it's just that it can > cause some undesired UX issues in some browsers, mainly that the popup > window will show up in the wrong place on the page. > > With that said I can easily turn off the javascript in the beta part > of the site and all the functionality would work as intended without > consequence. In the meant time with or without the javascript this > doesn't break any of the existing code. > > > As for the additions to the system; I've finally had some time to review > > what you've added and I think it looks ok. Personally there are only 2 > small > > things I'd change in the interface: > > 1. Don't have the popup window "slide" out, I hate that animation (but > > that's a personal thing I guess). Just have it pop up, that's more than > > enough; there's no reason to have to wait till it finishes appearing once > > clicked (and yes, I do know it's pretty fast. Like I said, it's a > personal > > thing). > > 2. Change the input field for the reason why a note is reported from > input > > to textarea. Many people often like to give more than 2 words of > reasoning. > > Even if they only want to explain it in 2 words, they then still can. > But it > > makes it easier to read. > > > > I intentionally didn't use a textare in the hopes that it might deter > people from writing endless jibber jabber about who knows what that > might not be of any real consequence. My intention was to encourage > short descriptive headings one could read to get an idea of what needs > looked at in the note. My feeling is that less is more here. I might > be wrong, but I have a good compromise here. I can use javascript to > to expand the size of the textbox to a multiline textarea once the > user has typed beyond the viewspace of the input field. :) > > > Other than that, I like the interface. I also the think the whole idea is > > ok. Not too sure of the usefulness of voting down and reporting at the > same > > time, as Magnus also mentioned, but I guess we could have a pilot for > that > > of a kind. Keep it for say 6 months and see if it has any (positive) > effect. > > If it doesn't, we can remove it; otherwise we'll know it's good. > > > > - Tul >
