Status: Accepted
Owner: allain.lalonde
Labels: Type-Defect Priority-Medium Effort-Low OpSys-All  
Toolkit-Piccolo2D.Java Component-Extras Milestone-1.3

New issue 136 by allain.lalonde: PNotificationCenter is a singleton but  
isn't declared as final
http://code.google.com/p/piccolo2d/issues/detail?id=136

Regardless of whether you think singleton's are evil, PNotificationCenter is
one. It's constructor is private, it has an singleton accessor, and it even
calls itself a singleton.

It does not declare itself as final however so that anyone wishing to create
multiple instances of it can do so easily by subclassing it.

This is another one of those binary incompatibilities I'd be game for since
the clients it would break would be using it in a way that Piccolo clearly
went out of its way to allow in the first place.

Thoughts?


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to