Santhosh Srinivasan commented on PIG-652:

Review comments:

1. In JobControlCompiler, the use of a static final string is a good idea to 
remove the use of string constants. We should probably make this change across 
the board as part of a new JIRA

2. Will schemas be useful for other operators and not just POStore?

3. StoreConfig implements Serializable, it should also have a static final long 

The rest of the code is good. I have not run any of the tests, this was a pure 
code review.

> Need to give user control of OutputFormat
> -----------------------------------------
>                 Key: PIG-652
>                 URL: https://issues.apache.org/jira/browse/PIG-652
>             Project: Pig
>          Issue Type: New Feature
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Alan Gates
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>         Attachments: PIG-652.patch
> Pig currently allows users some control over InputFormat via the Slicer and 
> Slice interfaces.  It does not allow any control over OutputFormat and 
> RecordWriter interfaces.  It just allows the user to implement a storage 
> function that controls how the data is serialized.  For hadoop tables, we 
> will need to allow custom OutputFormats that prepare output information and 
> objects needed by a Table store function.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to