Pradeep Kamath updated PIG-652:

    Attachment: PIG-652-v2.patch

Attached new version which addresses the comment regarding having a 
serialVersionUID in StoreConfig since it its Serializable. Also removed a 
redundant import from StoreFunc.java.

Moving the string constants to a separate PropertyKeys.java file would be good 
but to be useful will need all existing free standing constants to be moved 
there - this would be good in a separate jira as suggested.

Having schemas in all PhysicalOperators might be good but would need all the 
visitors (optimizers etc) which run after LogToPhyTranslationVisitor  and which 
introduce new PhysicalOperators to also generate schema for them. Likewise 
these visitor would have to handle schema changes on operators they modify - 
this might be better pursued in a different jira is found to be worthwhile.

> Need to give user control of OutputFormat
> -----------------------------------------
>                 Key: PIG-652
>                 URL: https://issues.apache.org/jira/browse/PIG-652
>             Project: Pig
>          Issue Type: New Feature
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Alan Gates
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>         Attachments: PIG-652-v2.patch, PIG-652.patch
> Pig currently allows users some control over InputFormat via the Slicer and 
> Slice interfaces.  It does not allow any control over OutputFormat and 
> RecordWriter interfaces.  It just allows the user to implement a storage 
> function that controls how the data is serialized.  For hadoop tables, we 
> will need to allow custom OutputFormats that prepare output information and 
> objects needed by a Table store function.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to