[ 
https://issues.apache.org/jira/browse/PIG-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thejas M Nair updated PIG-544:
------------------------------

    Attachment: PIG-544.txt

Patch.
- DataReaderWriter bytestoX logic for complex datatypes  re-factored into 
separate functions in same class and used by BinStorage.
- Utf8StorageConverter logs warning and returns null if type conversions fail.
- Moved logging utility functions from org.apache.pig.tools.grunt.Utils to 
org.apache.pig.impl.util.LogUtils. Updated files that used grunt.Utils .
- Added unit test cases for type conversion failures in TestEvalPipeline2 .


> Utf8StorageConverter.java does not always produce NULLs when data is malformed
> ------------------------------------------------------------------------------
>
>                 Key: PIG-544
>                 URL: https://issues.apache.org/jira/browse/PIG-544
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Olga Natkovich
>            Assignee: Thejas M Nair
>             Fix For: types_branch
>
>         Attachments: PIG-544.txt
>
>
> It does so for scalar types but not for complext types and not for the fields 
> inside of the complext types.
> This is because it uses different code to parse scalar types by themselves 
> and scalar types inside of a complex type. It should really use the same (its 
> own code to do so.)
> The code it is currently uses, is inside of TextDataParser.jjt and is also 
> used to parse constants so we need to be careful if we want to make changes 
> to it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to