[ 
https://issues.apache.org/jira/browse/PIG-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764860#action_12764860
 ] 

Dmitriy V. Ryaboy commented on PIG-990:
---------------------------------------

Thanks for reviewing.

I only called it "regular" because that's what it was called in the enum that 
already existed inside LOJoin.

Maybe a better option would be to call the currently-default join 'hash', and 
also provide a 'default' key that, for now, will translate to hash, but can 
translate to something else (and stay pinned) if the defaults change. I'll add 
that to the next iteration of the patch (which will also contain whatever 
keyword is decided on for the map-side groups).

> Provide a way to pin LogicalOperator Options
> --------------------------------------------
>
>                 Key: PIG-990
>                 URL: https://issues.apache.org/jira/browse/PIG-990
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Dmitriy V. Ryaboy
>            Priority: Minor
>             Fix For: 0.6.0
>
>         Attachments: pinned_options.patch
>
>
> This is a proactive patch, setting up the groundwork for adding an optimizer.
> Some of the LogicalOperators have options. For example, LOJoin has a variety 
> of join types (regular, fr, skewed, merge), which can be set by the user or 
> chosen by a hypothetical optimizer.  If a user selects a join type, pig 
> philoophy guides us to always respect the user's choice and not explore 
> alternatives.  Therefore, we need a way to "pin" options.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to