[
https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thejas M Nair updated PIG-1094:
-------------------------------
Attachment: PIG-1094_5.patch
This patch (PIG-1094_5.patch) fixes the order-by, skew-join and merge-join test
failures.
TestPoissonSampleLoader.java - testNumSamples() - Unlike earlier version of
sampler, if there are very few rows (3 in this case) only one sample is
selected.
WeightedRangePartitioner.java - If the sample file is empty, there was a check
to ensure that the input is also empty , using FileLocalizer.getSize(). Removed
that check. Input location need not be a file.
PoissonSampleLoader.java - additional comments, fixed indentation .
GetMemNumRows.java - handling the case where 2nd last column is null (while
looking for the specially marked last tuple).
output of test-patch -
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
> Key: PIG-1094
> URL: https://issues.apache.org/jira/browse/PIG-1094
> Project: Pig
> Issue Type: Sub-task
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch,
> PIG-1094_4.patch, PIG-1094_5.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit
> test failures due to interface changes. This jira is to track the task of
> making the common case unit tests work with the new interfaces. Some aspects
> of the new proposal like using LoadCaster interface for casting, making local
> mode work have not been completed yet. Tests which are failing due to those
> reasons will not be fixed in this jira and addressed in the jiras
> corresponding to those tasks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
