[ 
https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796316#action_12796316
 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

+1 to PIG-1094_6.patch , patch committed - thanks Thejas!

Here is the output of test-patch for the same:

  [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or 
modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec]
     [exec]
     [exec]


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, 
> PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit 
> test failures due to interface changes. This jira is to track the task of 
> making the common case unit tests work with the new interfaces. Some aspects 
> of the new proposal like using LoadCaster interface for casting, making local 
> mode work have not been completed yet. Tests which are failing due to those 
> reasons will not be fixed in this jira and addressed in the jiras 
> corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to