[ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865722#action_12865722 ]
Hadoop QA commented on PIG-1410: -------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444081/Pig_1410.patch against trunk revision 941976. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/console This message is automatically generated. > Make PigServer can handle files with parameters > ----------------------------------------------- > > Key: PIG-1410 > URL: https://issues.apache.org/jira/browse/PIG-1410 > Project: Pig > Issue Type: Improvement > Affects Versions: 0.8.0 > Reporter: Jeff Zhang > Assignee: Jeff Zhang > Fix For: 0.8.0 > > Attachments: Pig_1410.patch > > > The current PigServer only support handle files without parameters, this task > is to extend PigServer's API. > Add there public methods: > > {code} > public void registerScript(String fileName, Map<String,String> params) // > put the parameters in the Map data datastructure > public void registerScript(String fileName, List<String> paramsFiles) // put > the parameters in the files > public void registerScript(String fileName, Map<String,String> > params,List<String> paramsFiles) // put the parameter both in files and Map, > the Map should override the parameter file if they have the same parameters > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.