[
https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865967#action_12865967
]
Alan Gates commented on PIG-1410:
---------------------------------
Comments:
# The catch blocks in registerScript(String, Map<String, String>, List<String>)
need to be filled out. They shouldn't be dumping stack traces to standard out
but instead should use the logging mechanism.
# The existing registerScript(String) should be rewritten in terms of
registerScript(String, Map<String, String>, List<String>). That way there is
only one "real" method doing hte work.
# (this one's a nitpick) registerScript(String, Map<String, String>) and
registerScript(String, List<String>) create empty lists and maps, and then the
real registerScript checks if those are empty and then treats them as null.
Why not just pass nulls?
> Make PigServer can handle files with parameters
> -----------------------------------------------
>
> Key: PIG-1410
> URL: https://issues.apache.org/jira/browse/PIG-1410
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Fix For: 0.8.0
>
> Attachments: Pig_1410.patch
>
>
> The current PigServer only support handle files without parameters, this task
> is to extend PigServer's API.
> Add there public methods:
>
> {code}
> public void registerScript(String fileName, Map<String,String> params) //
> put the parameters in the Map data datastructure
> public void registerScript(String fileName, List<String> paramsFiles) // put
> the parameters in the files
> public void registerScript(String fileName, Map<String,String>
> params,List<String> paramsFiles) // put the parameter both in files and Map,
> the Map should override the parameter file if they have the same parameters
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
