[
https://issues.apache.org/jira/browse/PIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575097#action_12575097
]
Olga Natkovich commented on PIG-94:
-----------------------------------
Arun, looks good.
A couple of comments:
(1) In StreamSpec.java, we check for non-null executor on every add. If it
would be better to precreate it upfront if possible. You don't want to have a
branch on every tuple.
(2) In the same code, in catch statement, there is no need to print the stack
or System.err. We are currently working on defining the error handling policy
and it seems that we are convergin on just throwing exceptions and the outer
layer will take care of logging.
> Pig Streaming functional spec proposal
> --------------------------------------
>
> Key: PIG-94
> URL: https://issues.apache.org/jira/browse/PIG-94
> Project: Pig
> Issue Type: New Feature
> Reporter: Olga Natkovich
> Attachments: PIG-94_1_20080303.patch
>
>
> This issue is for discussion about Pig streaming functional spec.
> http://wiki.apache.org/pig/PigStreamingFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
