[
https://issues.apache.org/jira/browse/PIG-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580762#action_12580762
]
Shravan Matthur Narayanamurthy commented on PIG-158:
----------------------------------------------------
Looks good to me Santosh. I have a couple of comments.
1) For the visitor, can we not type the Operator with the PhysicalPlan, and the
PlanVisitor with Operator and the OperatorPlan so that a lot of those
instanceof checks in the visit methods and in LOVisitor can be avoided.
2) Can you check the getSchema method of LOSort?
3) Why do we have an LOEval?
4) In LOGenerate, why is mProjections a List<LogicalOperator> instead of
List<ExpressionOperator>?
5) I think you need to look more into aliases. In many places you set it to
null but I felt there can be aliases attached to it. I am not sure abt this.
But pls check.
6) In LOForeach why do you have a List<LogicalOperators> mOperators? Instead I
was hoping that there will be a LogicalPlan. Then you will have LOGenerate as
the leaf node.
Thats as far as I could get :)
> Rework logical plan
> -------------------
>
> Key: PIG-158
> URL: https://issues.apache.org/jira/browse/PIG-158
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: logical_operators.patch
>
>
> Rework the logical plan in line with
> http://wiki.apache.org/pig/PigExecutionModel
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
