[ 
https://issues.apache.org/jira/browse/PIG-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581457#action_12581457
 ] 

Alan Gates commented on PIG-158:
--------------------------------

Shravan wrote:

>>In LOForeach why do you have a List<LogicalOperators> mOperators? Instead I 
>>was hoping that there will be a LogicalPlan. Then you will have LOGenerate as 
>>the leaf node.<<

We wanted to make LOForeach have a list of operators rather than a LogicalPlan 
because that makes it easier for visitors to traverse the plans.  As currently 
constructed, an LOVisitor knows the plan it is traversing.  If plans could 
contain plans than visitors have to be able to span plans, which makes visitors 
much more complex.  And, as Santhosh pointed out, I don't think that this 
flattening of plans into one can be done without loss of generality, because 
one of the logical operators that the foreach contains could in turn be a 
foreach.

> Rework logical plan
> -------------------
>
>                 Key: PIG-158
>                 URL: https://issues.apache.org/jira/browse/PIG-158
>             Project: Pig
>          Issue Type: Sub-task
>          Components: impl
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: logical_operators.patch
>
>
> Rework the logical plan in line with 
> http://wiki.apache.org/pig/PigExecutionModel

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to