[
https://issues.apache.org/jira/browse/PIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580854#action_12580854
]
Craig Macdonald commented on PIG-18:
------------------------------------
Olga,
1. This patch does not resolve the hard-coding of .inktomisearch.com, which
prevents us using Pig without patching in our own setting.
I don't see a need why this hack should remain any longer. Indeed it will break
compatability for internal users, but you have control over your internal
users. If suffixing ".inktomisearch.com" to any non FQDN remains, then any some
percentage of new users trying to use Pig through HOD will fail. It can be
simply replaced with a property, and given a good configuration implementation,
this will be a one-time only change for the users. Perhaps you should only move
your users when you reach a release status, and this prevents them being
interrupted while we try to determine the best way to configure Pig.
(If the above reads overly harshly, please accept my apologies, I'm not hear to
stir things up).
2. I would recommend change the spec of runCommand to (String, String[]). This
would be less likely to break in settings where the command line contains paths
with spaces. (Often on Windows ;-). In this case, you'd be using
runtime.exec(String[]) instead of runtime.exec(String). This is better as the
Java tokeniser is not as good as Unix shells at tokenising spaces, escapes,
double quotes etc [e.g Perl uses the Unix shell to tokenise for system("")
calls, while Java just splits on space]. Using the array method prevents the
tokenisation, and means arguments containing spaces wont be incorrectly
tokenised.
Other than that I'm happy to see this patch committed.
Craig
> Making Pig work with HOD 0.4 and hadoop 0.16
> --------------------------------------------
>
> Key: PIG-18
> URL: https://issues.apache.org/jira/browse/PIG-18
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Priority: Critical
> Attachments: hadoop16.jar, PIG-18.patch, PIG-18.patch,
> PIG-18.patch-v2craigm-07032008, PIG-18.patch-v3craigm-10032008
>
>
> Pig needs to work with the soon to be released hadoop on demand (HOD) version.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
