[
https://issues.apache.org/jira/browse/PIG-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596861#action_12596861
]
Alan Gates commented on PIG-161:
--------------------------------
A few comments on the logical to physical translator patch:
# The purpose of the scope value in the OperatorKey is to give a single value
by which all operators associated with a single job or a single session can be
easily discovered. So your class GenPhyOp should get the scope (probably
should be passed in as part of constructing the class (except that I note all
the methods are static) or otherwise initialized) and then use that when
generating the objects.
# GenPhyOp should use logicalLayer.parser.NodeIdGenerator rather than
generating random numbers for the OperatorKey
# LogToPhyTranslationVisitor should create its own walker, not depend on the
caller to create and pass it one. Each visitor should know how it wants to
walk the plan rather then letting it's instantiator decide for it. Same
applies to the Printer visitors in the patch.
> Rework physical plan
> --------------------
>
> Key: PIG-161
> URL: https://issues.apache.org/jira/browse/PIG-161
> Project: Pig
> Issue Type: Sub-task
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: arithmeticOperators.patch, BinCondAndNegative.patch,
> incr2.patch, incr3.patch, incr4.patch, incr5.patch, logToPhyTranslator.patch,
> MRCompilerTests_PlansAndOutputs.txt, Phy_AbsClass.patch, physicalOps.patch,
> physicalOps.patch, physicalOps.patch, physicalOps.patch,
> physicalOps_latest.patch, podistinct.patch, pogenerate.patch,
> pogenerate.patch, pogenerate.patch, posort.patch
>
>
> This bug tracks work to rework all of the physical operators as described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
