[ 
https://issues.apache.org/jira/browse/PIG-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597240#action_12597240
 ] 

Alan Gates commented on PIG-161:
--------------------------------

One issue with POCast.  Rather than assuming that it can cast directory from 
ByteArray to whatever type, it should be calling the load function that was 
used to acquire the data, as we don't necessarily know how to convert bytearray 
data into a given type (that is, we can't assume we can call toString on it and 
then go from there).  That means that POCast will need to know the load 
function used to load the data it's casting.

Everything else looks good.  I stripped out the cast stuff and committed the 
map lookup stuff.  So when you resubmit the patch you just need POCast and its 
unit tests.

> Rework physical plan
> --------------------
>
>                 Key: PIG-161
>                 URL: https://issues.apache.org/jira/browse/PIG-161
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: arithmeticOperators.patch, BinCondAndNegative.patch, 
> CastAndMapLookUp.patch, incr2.patch, incr3.patch, incr4.patch, incr5.patch, 
> logToPhyTranslator.patch, MRCompilerTests_PlansAndOutputs.txt, 
> Phy_AbsClass.patch, physicalOps.patch, physicalOps.patch, physicalOps.patch, 
> physicalOps.patch, physicalOps_latest.patch, podistinct.patch, 
> pogenerate.patch, pogenerate.patch, pogenerate.patch, posort.patch
>
>
> This bug tracks work to rework all of the physical operators as described in 
> http://wiki.apache.org/pig/PigTypesFunctionalSpec

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to