[ 
https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603906#action_12603906
 ] 

Alan Gates commented on PIG-162:
--------------------------------

Comments on changes.patch:

In JobControlCompiler, it looks like we're setting the comparator as binary 
only in the case of tuples.  Why not in the case of other data types too?

For group all, we should choose a numeric 1 instead of string 'all' for the 
group key.  Comparison should be faster, and we're transmitting less data.

You had originally wanted to integrate the local and map reduce launchers.  Why 
did you change your mind and separate them out?

The changes to get rid of all the 'if (func == null) instantitateFunc()" in 
POUserFunc look great.



> Rework mapreduce submission and monitoring
> ------------------------------------------
>
>                 Key: PIG-162
>                 URL: https://issues.apache.org/jira/browse/PIG-162
>             Project: Pig
>          Issue Type: Sub-task
>         Environment: This bug tracks works to rework the submission and 
> monitoring interface to map reduce as described in  
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: changes.patch, changes1.patch, incr7.patch, incr8.patch, 
> mapreduceJumbo.patch, mapreduceJumboWithComInc.patch, modJumbo.patch, 
> split.png, TEST-org.apache.pig.test.TestMapReduce.txt, 
> TEST-org.apache.pig.test.TestMRCompiler.txt, 
> TEST-org.apache.pig.test.TestMRCompiler.txt, 
> TEST-org.apache.pig.test.TestUnion.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to