[ 
https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603958#action_12603958
 ] 

Shravan Matthur Narayanamurthy commented on PIG-162:
----------------------------------------------------

1) Binary comparator for other data types - Since we use WritableComparable 
forms of the pig types, they automatically support this.

2) Using 1 instead of 'all' - I think it should be all. How would we otherwise 
distinguish it from a genuine case of group by where 1 happens to be the key? 
Because in Package we would need to identify that it is a 1 and change it to 
'all'. Or are you suggesting that we change the current syntax of putting 'all' 
in the group field of a group all query?

3) I guess I did not have the context to decide what was right. When called in 
local mode, there is LocalExecution engine which does not support calls like 
getJobClient and the call to getConfiguration would have to be casted to 
HConfig only if its a map reduce call. Instead of introducing branches there, I 
thought it would be clearer to just separate out the two.

4) Thanks.

> Rework mapreduce submission and monitoring
> ------------------------------------------
>
>                 Key: PIG-162
>                 URL: https://issues.apache.org/jira/browse/PIG-162
>             Project: Pig
>          Issue Type: Sub-task
>         Environment: This bug tracks works to rework the submission and 
> monitoring interface to map reduce as described in  
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: changes.patch, changes1.patch, incr7.patch, incr8.patch, 
> mapreduceJumbo.patch, mapreduceJumboWithComInc.patch, modJumbo.patch, 
> split.png, TEST-org.apache.pig.test.TestMapReduce.txt, 
> TEST-org.apache.pig.test.TestMRCompiler.txt, 
> TEST-org.apache.pig.test.TestMRCompiler.txt, 
> TEST-org.apache.pig.test.TestUnion.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to