[ 
https://issues.apache.org/jira/browse/PIG-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614593#action_12614593
 ] 

Amir Youssefi commented on PIG-139:
-----------------------------------

Good move. It partially works:

Demonstrating by example: 

ARITY is in pig/branches/types/autocomplete

+ : It works when that's local dir.

- : It doesn't work when current directory is elsewhere and above is in Class 
Path (I used java -cp ... to run)

+ :  src/org/apache/pig/tools/grunt/autocomplete works (e.g. LOAD or load which 
is not in pig/branches/types/autocomplete) . 


+ : I see that you have case sensitivity so one has to have both LOAD and load 
there in keywords list.  ARITY is in local autocomplete but not arity and only 
ARITY works. Good thing is that user's preference is applied, meaning if user 
meant load or LOAD (s)he gets it in correct case. Since some of the 
autocomplete cases (e.g. Piggy Bank classes) are case sensitive, having 
case-sensitivity in output is definitely needed. We can add functionality of 
correct case even though input is not correct case. I'm not sure if it worth 
the effort. Example: we could convert math.floo<tab> to math.FLOOR and correct 
the case. Perhaps it would be better to wrap it up for now.





> Command line editing, history and more for Grunt
> ------------------------------------------------
>
>                 Key: PIG-139
>                 URL: https://issues.apache.org/jira/browse/PIG-139
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: types_branch
>         Environment: Grunt
>            Reporter: Amir Youssefi
>             Fix For: types_branch
>
>         Attachments: jline-0.9.94.jar, jline.patch, jline2.patch
>
>
> We need to add support of command line editing, history and more for Grunt. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to