On 14/05/12 16:05, Brian Paul wrote:
On 05/14/2012 08:59 AM, Brian Paul wrote:
On 05/14/2012 08:49 AM, [email protected] wrote:
From: James Benton<[email protected]>

Ensures correct rasterisation by comparing a randomly drawn triangle
against a software rasteriser.
The software rasteriser complies with the GL spec and has been
verified against nvidia drivers.

V2: Added argument for using maximum texture size
---
tests/general/CMakeLists.gl.txt | 1 +
tests/general/triangle-rasterisation.cpp | 556
++++++++++++++++++++++++++++++

One minor nit: in the OpenGL spec, it's spelled "rasterization". I
have no objection to the "s" spelling other than someone who wants to
run piglit tests related to GL rasterization would probably expect to
see the spec's spelling.

The test looks great otherwise. Do you have piglit commit ability?

Reviewed-by: Brian Paul <[email protected]>

Oh, you should also add the new test to piglit/tests/all.tests

-Brian

I did the changes you suggested, including stencil buffer instead of logic ops.

I do not have piglit commit ability, however Jose will commit the changes for me.

Thanks for the review,
- James

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to