On 01/14/2013 11:55 AM, Eric Anholt wrote:
---
tests/fbo/fbo-alphatest-formats.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/fbo/fbo-alphatest-formats.c
b/tests/fbo/fbo-alphatest-formats.c
index a8d2453..c3f539a 100644
--- a/tests/fbo/fbo-alphatest-formats.c
+++ b/tests/fbo/fbo-alphatest-formats.c
@@ -176,12 +176,11 @@ static enum piglit_result test_format(const struct
format_desc *format)
assert(glGetError() == 0);
status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT);
- printf("Testing %s", format->name);
if (status != GL_FRAMEBUFFER_COMPLETE_EXT) {
- printf(" - fbo incomplete (status = 0x%04x)\n", status);
+ printf("fbo incomplete (status = 0x%04x)\n", status);
Maybe use piglit_get_gl_enum_name() for string instead of hexadecimal.
+ piglit_report_subtest_result(PIGLIT_SKIP, format->name);
return PIGLIT_SKIP;
}
- printf("\n");
glClearColor(0.0, 0.0, 0.0, 0.0);
glClear(GL_COLOR_BUFFER_BIT);
@@ -251,6 +250,7 @@ static enum piglit_result test_format(const struct
format_desc *format)
if (!pass) {
piglit_present_results();
+ piglit_report_subtest_result(PIGLIT_FAIL, format->name);
return PIGLIT_FAIL;
}
@@ -311,6 +311,8 @@ static enum piglit_result test_format(const struct
format_desc *format)
piglit_present_results();
+ piglit_report_subtest_result(pass ? PIGLIT_PASS : PIGLIT_FAIL,
+ format->name);
return pass ? PIGLIT_PASS : PIGLIT_FAIL;
}
The series looks good to me.
Reviewed-by: Brian Paul <[email protected]>
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
