Eric Anholt <[email protected]> writes: > - printf("Testing %s", format->name); > if (status != GL_FRAMEBUFFER_COMPLETE_EXT) { > - printf(" - fbo incomplete (status = 0x%04x)\n", status); > + printf("fbo incomplete (status = 0x%04x)\n", status); > + piglit_report_subtest_result(PIGLIT_SKIP, format->name); > return PIGLIT_SKIP; > } > - printf("\n");
The patch should be updated to not remove these printf calls. Without these, it's really hard to distinguish which portions of the test output correspond to which formats. (At least, that's the case in the HTML output where the piglit report lines have been stripped out.) Similarly for fbo-colormask-formats and fbo-alphatest-formats, (and presumably others, but those are the ones I've actually looked at). With that change, these patches get my: Reviewed-by: Carl Worth <[email protected]> And it's very helpful, thanks! -Carl
pgp29Ee98L5GP.pgp
Description: PGP signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
