Brian Paul <[email protected]> writes: > +void > +piglit_init(int argc, char **argv) > +{ > + bool pass; > + > + if (piglit_get_gl_version() < 30 > + && !(piglit_is_extension_supported("GL_EXT_packed_depth_stencil") && > + piglit_is_extension_supported("GL_ARB_framebuffer_object"))) { > + printf("OpenGL 3.0 or GL_EXT_packed_depth_stencil + " > + "GL_ARB_framebuffer_object is required.\n"); > + piglit_report_result(PIGLIT_SKIP); > + }
I'm confused what ARB_fbo has to do with the test. Isn't this test just
using EXT_packed_depth_stencil?
> +
> + pass = test_z24_s8();
> +
> + if (piglit_get_gl_version() >= 30 ||
> + piglit_is_extension_supported("GL_NV_depth_buffer_float")) {
> + pass = test_z32_s8() && pass;
> + }
> +
> + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
Checking for NV_depth_buffer_float seems weird when we only advertise
GL_ARB_depth_buffer_float.
Other than these two comments,
Reviewed-by: Eric Anholt <[email protected]>
pgpjf_5tR411h.pgp
Description: PGP signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
