On 02/28/2014 12:49 AM, Eric Anholt wrote:
Brian Paul <[email protected]> writes:+void +piglit_init(int argc, char **argv) +{ + bool pass; + + if (piglit_get_gl_version() < 30 + && !(piglit_is_extension_supported("GL_EXT_packed_depth_stencil") && + piglit_is_extension_supported("GL_ARB_framebuffer_object"))) { + printf("OpenGL 3.0 or GL_EXT_packed_depth_stencil + " + "GL_ARB_framebuffer_object is required.\n"); + piglit_report_result(PIGLIT_SKIP); + }I'm confused what ARB_fbo has to do with the test. Isn't this test just using EXT_packed_depth_stencil?
I based this on code copied from the depth-stencil-texture.c test, but I think I got it wrong.
From the EXT_packed_depth_stencil spec, it sounds like packed depth/stencil textures are only supported if GL_ARB_depth_texture is also supported.
So I think my code above should s/GL_ARB_framebuffer_object/GL_ARB_depth_texture/
+ + pass = test_z24_s8(); + + if (piglit_get_gl_version() >= 30 || + piglit_is_extension_supported("GL_NV_depth_buffer_float")) { + pass = test_z32_s8() && pass; + } + + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL); +}Checking for NV_depth_buffer_float seems weird when we only advertise GL_ARB_depth_buffer_float.
Right. I'll fix that. I'll post a v2.
Other than these two comments, Reviewed-by: Eric Anholt <[email protected]>
-Brian _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
