On 04/03/2014 03:42 AM, Fu, Ping wrote:
Hi Justen,
I tested the latest piglit and found lots of crashes(Over three
thousand) on both AMD and NVIDIA. This might be caused by your commit
b28cdc887aefb1e766719e1f74d457f77bdf9a18 on shader_runner.c.
According to page 363 and 360 of glspec44.compatibility for
glVertexPointer: “An INVALID_OPERATION error is generated if a non-zero
vertex array object is bound, no buffer is bound to ARRAY_BUFFER, and
pointer is not NULL.” So if app who wants to use VAO, should obey the
following gl call sequence:
glGenVertexArrays
glBindVertexArray
glGenBuffers
glBindBuffer
glBufferData
glVertexAttribPointer
But now the red part missed under current code path when
use_fixed_function_attributes and INVALID_OPERATION was returned by
subsequent glVertexAttribPointer. Then both AMD and NVIDIA crashed on
subsequent glDrawArrays. Besides, mesa driver’s gl_version=30 so it
followed another code path which didn’t use VAO, and had no crash.
Thanks for investigating that! I saw a ton of failures on NVIDIA too in
a recent test run that I did. I didn't have time to did into it though.
-Brian
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
