On 05/09/2014 01:21 PM, Dylan Baker wrote: > This Adds a new python generator to replace the shell generator. The old > generator was run once and the results were checked into git, the python > generator on the other hand is run at build time. > > The tests are equivalent with only whitespace differences. > > Signed-off-by: Dylan Baker <[email protected]>
I verified that these tests are equivalent, aside from whitespace changes. Patches 1-3 are: Reviewed-by: Kenneth Graunke <[email protected]> Patch 5 is: Acked-by: Kenneth Graunke <[email protected]> Patch 6 seems to have gotten stuck in the moderation queue, but I grabbed your branch and looked at it. There is a typo: -# glUniformMatrix4x2fv only exists in OpenGL 2.1 or later. +# glUniformMatrix4x2fv only exits in OpenGL 2.1 or later "exits" vs "exists", and the trailing period. Also, it would be nice to preserve the space after "probe" and before the next set of "uniform" calls...but not a big deal. With the typos fixed, patch 6 is: Acked-by: Kenneth Graunke <[email protected]> Thanks for doing this! It's really nice to not have all this generated stuff in revision control. And, using Python for this is a lot nicer than Bash. --Ken
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
