On 07/08/2014 11:01 AM, Matthew McClure wrote:
I ran this on Ubuntu 12.04.3 with:
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GTX 650/PCIe/SSE2
OpenGL version string: 4.2.0 NVIDIA 304.116
OpenGL shading language version string: 4.20 NVIDIA via Cg compiler
OpenGL extensions:
.../Devel/fdo.piglit$ bin/gl-3.0-bound-resource-limits -auto
GL_MAX_VARYING_FLOATS: 124
GL_MAX_VERTEX_ATTRIBS: 16
GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS: 32
GL_MAX_TEXTURE_IMAGE_UNITS: 32
GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS: 160
GL_AUX_BUFFERS: 4
GL_MAX_DRAW_BUFFERS: 8
GL_MAX_COLOR_ATTACHMENTS: 8
g_expected[0]=(23921766400.000000, 86156951552.000000, 480410238976.000000,
1425854431232.000000)
g_expected[1]=(6227219709952.000000, 11347125338112.000000,
27230952488960.000000, 41933363740672.000000)
g_expected[2]=(81694296113152.000000, 171963293106176.000000,
241784881938432.000000, 428522141122560.000000)
g_expected[3]=(623247401943040.000000, 751236219404288.000000,
1125101110034432.000000, 1856184336252928.000000)
g_expected[4]=(2735942485934080.000000, 3101938392498176.000000,
4440612589797376.000000, 5674358320136192.000000)
g_expected[5]=(6377906712346624.000000, 8903007106236416.000000,
11072865923235840.000000, 14685310302552064.000000)
g_expected[6]=(20124361323184128.000000, 23577553683873792.000000,
26507988395098112.000000, 31646100720975872.000000)
g_expected[7]=(178482200576.000000, 207579496448.000000, 313797935104.000000,
351675613184.000000)
PIGLIT: {"result": "pass" }
Below are my replies:
+static char *
+get_packed_decl(PackedDesc *desc,
+ char *str,
+ unsigned strSize,
+ char *tmpStr,
+ unsigned tmpStrSize)
Here and elsewhere, can you const-qualify any pointer args to help
understand which are inputs vs. outputs?
Sounds good. I'll make the changes.
+setup_vertex_element_buffers()
I think MSVC warns on () so we use (void) usually.
Thanks, I'll go ahead and add that.
The code generally looks good, but is a bit dense. It would take me a
while to understand the intricacies.
In any case, when I tested it with my nvidia driver I got a failure:
$ bin/gl-3.0-bound-resource-limits -auto
GL_MAX_VARYING_FLOATS: 124
GL_MAX_VERTEX_ATTRIBS: 16
GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS: 32
GL_MAX_TEXTURE_IMAGE_UNITS: 32
GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS: 192
GL_AUX_BUFFERS: 4
GL_MAX_DRAW_BUFFERS: 8
GL_MAX_COLOR_ATTACHMENTS: 8
Failed to link: Fragment info
-------------
0(8) : warning C7533: global variable gl_FragData is deprecated after
version 120
0(2) : error C5041: cannot locate suitable resource to bind variable
"Variable". Possibly large array.
PIGLIT: {"result": "fail" }
What was your NVIDIA driver version?
325.15
-Brian
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
