Weren't you guys going to flip ARB_dsa to be core-only? Then you'll need to set supports_gl_core_version = 32 for the test to actually run... [And remove the compat version support.]
On Thu, Feb 26, 2015 at 10:41 AM, Martin Peres <[email protected]> wrote: > Also add the relevant quote from the spec. > > Signed-off-by: Martin Peres <[email protected]> > --- > .../arb_direct_state_access/create-transformfeedbacks.c | 14 > +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/tests/spec/arb_direct_state_access/create-transformfeedbacks.c > b/tests/spec/arb_direct_state_access/create-transformfeedbacks.c > index f837c13..1419632 100644 > --- a/tests/spec/arb_direct_state_access/create-transformfeedbacks.c > +++ b/tests/spec/arb_direct_state_access/create-transformfeedbacks.c > @@ -25,6 +25,14 @@ > * > * Tests glCreateTransformFeedbacks to see if it behaves in the expected way, > * throwing the correct errors, etc. > + * > + * From OpenGL 4.5, section 13.2.1 "Transform Feedback Objects", page 420: > + * > + * "CreateTransformFeedbacks returns n previously unused transform feedback > + * object names in ids, each representing a new state vector, comprising the > + * state and with all the same initial values listed in table 23.48. > + * Errors > + * An INVALID_VALUE error is generated if n is negative." > */ > > #include "piglit-util-gl.h" > @@ -32,7 +40,7 @@ > > PIGLIT_GL_TEST_CONFIG_BEGIN > > - config.supports_gl_compat_version = 13; > + config.supports_gl_compat_version = 20; > > config.window_visual = PIGLIT_GL_VISUAL_RGBA | > PIGLIT_GL_VISUAL_DOUBLE; > @@ -71,5 +79,9 @@ piglit_display(void) > SUBTESTCONDITION(glIsTransformFeedback(ids[2]), pass, > "IsTransformFeedback()"); > > + /* the default state is tested in the following piglit test: > + * arb_direct_state_access-gettransformfeedback > + */ > + > return pass ? PIGLIT_PASS : PIGLIT_FAIL; > } > -- > 2.3.0 > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
