So a test that otherwise passes (i.e. has a "pass" result code) but generates errors in dmesg will get converted to a "dmesg-warn" code. You were previously treating those as failures, but now will treat them as success.
I don't feel strongly either way, but just wanted to point it out for your consideration. Also adding Jose who IIRC is also a junit user. [I, btw, am not.] On Fri, Jun 26, 2015 at 1:40 PM, Mark Janes <[email protected]> wrote: > JUnit has no concept of "warning". It supports the following > statuses: > > - skip > - success > - fail > - error > > dEQP has been found to intermittently emit warnings for passed tests, > and this status is accurately represented in piglit json. However, > current JUnit transforms them into failures. > > A test which emits a warning is more accurately represented as > "success" in JUnit. > --- > framework/backends/junit.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/framework/backends/junit.py b/framework/backends/junit.py > index 632e516..7499829 100644 > --- a/framework/backends/junit.py > +++ b/framework/backends/junit.py > @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend): > if data['result'] == 'skip': > res = etree.SubElement(element, 'skipped') > > - elif data['result'] in ['warn', 'fail', 'dmesg-warn', > - 'dmesg-fail']: > + elif data['result'] in ['fail', 'dmesg-fail']: > if expected_result == "failure": > err.text += "\n\nWARN: passing test as an expected > failure" > res = etree.SubElement(element, 'skipped', > -- > 2.1.4 > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
