On Wed, Jul 01, 2015 at 07:27:18PM -0400, Ilia Mirkin wrote: > On Wed, Jul 1, 2015 at 7:25 PM, Dylan Baker <[email protected]> wrote: > > On Wed, Jul 01, 2015 at 07:14:59PM -0400, Ilia Mirkin wrote: > >> On Wed, Jul 1, 2015 at 7:04 PM, Dylan Baker <[email protected]> > >> wrote: > >> > This adds a couple more unit tests, and a few fixes to the last version > >> > of this series, with the notable addition being support xz compression > >> > > >> > Ilia: how would you feel about dropping shell support and just using > >> > backports.lzma or not having xz support? > >> > >> No one's going to have it... I do see it in portage though. But I also > >> don't immensely see the problem with just supporting shelling out to > >> the binary. But I also haven't read the code yet :) > > > > Well, my assumption is that using pip backports.lzma would work on > > windows and OSX (I don't know if it has an xz binary or not), while > > shoveling things out to the shell only works on Unices (probably). > > AKA 99.9% of piglit's userbase :)
Probably more like 90%, but point taken. > > > > > I don't care too much either way, really. It would just be a lot less > > code. > > > > Dylan
signature.asc
Description: Digital signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
