On 1 November 2015 at 22:53, Timothy Arceri <[email protected]> wrote: > On Tue, 2015-10-27 at 15:34 +0000, Emil Velikov wrote: >> Hi all, > > Hi Emil, > > A few comments: > > - Patches 1-4 all have extra whitespace > Did not notice these. Thanks will fix.
> - Your a bunch or your tests require the extension and also the glsl verion to > be 4.30 where we know the extension will exist. You should instead change the > glsl version to the lowest version that the extension requires otherwise these > test will not be run on Mesa until a driver enables 4.30. > As mentioned elsewhere - I've added the 4.30 requirement is due to the std430 qualifier. > - I've made some additional comments on patch 3 and 5 > > - Change the check_link to true in patches 3 and 4 and then you can add to the > all the commit messages something like: > Test results: > Nvidia GeForce 840M - > NVIDIA 352.41: pass > These actually puzzle me quite a bit. The spec is quite clear that those should be a compile-time errors. By setting the check_link, we'll be doing a link-time check. Should we ignore the Nvidia's driver behaviour, or just toggle it on and add a note "this should really be off, as we want to do a compile-time check" like note ? Thanks for having a look Tim ! -Emil _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
