Seems reasonable. You could, if you _really_ cared, remove that ext from required exts, and then flip it to : enable, and then add
#ifdef GL_OES_texture_storage_multisample_2d_array #endif around the 2DMSArray ones. But that's *wholly* optional. Reviewed-by: Ilia Mirkin <[email protected]> On Wed, Aug 31, 2016 at 6:23 PM, Dylan Baker <[email protected]> wrote: > This test has two problems. > 1) It uses the OpenGL ARB extension instead of the OES extension > 2) It doesn't include that extension in the require block. > 3) It doesn't specify any precision > > v2: - replace GL_ARB_texture_storage with the OES equivalent (Ilia) > - Add precision specifiers > > Signed-off-by: Dylan Baker <[email protected]> > cc: Ian Romanick <[email protected]> > cc: Ilia Mirkin <[email protected]> > --- > .../glsl-es-3.10/compiler/all-functions.frag | 19 > ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git > a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag > > b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag > index c538aaf..380b979 100644 > --- > a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag > +++ > b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag > @@ -1,21 +1,22 @@ > // [config] > // expect_result: pass > // glsl_version: 3.10 > -// require_extensions: GL_EXT_shader_samples_identical > +// require_extensions: GL_EXT_shader_samples_identical > GL_OES_texture_storage_multisample_2d_array > // [end config] > > #version 310 es > -#extension GL_ARB_texture_multisample: require > +#extension GL_OES_texture_storage_multisample_2d_array: require > #extension GL_EXT_shader_samples_identical: require > > -uniform sampler2DMS s1; > -uniform isampler2DMS s2; > -uniform usampler2DMS s3; > -uniform sampler2DMSArray s4; > -uniform isampler2DMSArray s5; > -uniform usampler2DMSArray s6; > > -out vec2 data; > +uniform mediump sampler2DMS s1; > +uniform mediump isampler2DMS s2; > +uniform mediump usampler2DMS s3; > +uniform mediump sampler2DMSArray s4; > +uniform mediump isampler2DMSArray s5; > +uniform mediump usampler2DMSArray s6; > + > +out mediump vec2 data; > > void main() > { > -- > 2.9.3 > _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
