Quoting Marek Olšák (2016-10-25 03:41:15) > On Mon, Oct 24, 2016 at 8:09 PM, Dylan Baker <[email protected]> wrote: > > I agree with Ilia that making regressions and fixes non-symmetric is bad. > > So at > > the very least I'd want to see the same change to fixes. > > > > The regressions page was designed that someone could run piglit using "git > > rebase -x" and see what was regressing at each step along the way, and this > > change would definitely break that workflow. Wether anyone does that (or > > something like it) I don't know. > > Totally not true. :) It was originally designed to compare 2 runs and > show transitions such as {pass,skip} -> {fail, crash} and {fail} -> > {crash}. > > If this series doesn't change the behavior when comparing 2 runs, it's > OK with me. > > Marek
Okay, since you wrote the original implementation that's fair. That *was* my workflow for testing this feature when I rewrote the summary code the second time. Dylan
signature.asc
Description: signature
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
