On 21/11/16 11:55, Olender, Sebastian D wrote: > Well, the extensions expose much more formats than is required in 3.1 context. > You could support 3.1 without exposing GL_ARB_texture_buffer_object as long > as you don't support all of internal formats listed in extension.
Ah ok, makes sense. Thanks for the explanation. The patch is: Reviewed-by: Alejandro Piñeiro <[email protected]> > > > S. > > -----Original Message----- > From: Alejandro Piñeiro [mailto:[email protected]] > Sent: Monday, November 21, 2016 2:42 PM > To: Olender, Sebastian D <[email protected]>; > [email protected] > Subject: Re: [Piglit] [Patch] arb_internalformat_query2: GL_TEXTURE_BUFFER is > also in core since 3.1 > > On 21/11/16 10:43, Sebastian Olender wrote: >> GL_TEXTURE_BUFFER requires GL_ARB_texture_buffer_object extension or >> context greater than 3.1 > AFAIU, if the context is greater that 3.1, GL_ARB_texture_buffer_object is > exposed. Is there any case where the context is greater than 3.1 but the > extension is not exposed? > >> --- >> tests/spec/arb_internalformat_query2/common.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tests/spec/arb_internalformat_query2/common.c >> b/tests/spec/arb_internalformat_query2/common.c >> index 3454ed0..a5686c0 100644 >> --- a/tests/spec/arb_internalformat_query2/common.c >> +++ b/tests/spec/arb_internalformat_query2/common.c >> @@ -706,7 +706,8 @@ check_query2_target_dependencies(const GLenum target) >> break; >> >> case GL_TEXTURE_BUFFER: >> - if >> (!piglit_is_extension_supported("GL_ARB_texture_buffer_object")) >> + if >> (!piglit_is_extension_supported("GL_ARB_texture_buffer_object") && >> + piglit_get_gl_version() < 31) >> return false; >> break; >> _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
