Re-adding the piglit-list, since this is relevant. In general each "OpenGL x.y" folder denotes features that are new or changed in that particular version. I'm not really qualified to say whether a test should be changed or not, other's might have more to say on that.
Dylan Quoting sandra koroniewska (2017-05-08 01:33:22) > Hi, > I have a question about this issue. I found some other tests that are not > compatible with the newest spec. But they are, like this test, in the folders > named like older openGL versions. What about backward compatibility? I mean, > this test is requesting OpenGL 3.1 version so why are the tests divided by > OpenGL version if we are supposed to make them compatible with the newest > version? > > Regards, > Sandra > > On Fri, May 5, 2017 at 11:51 PM, Dylan Baker <[email protected]> wrote: > > I might suggest that if the visual studio you're using is < 2017, that you > install the editorconfig plugin (VS 2017 has built in support for > editorconfig). Piglit has a .editorconfig file which will automatically > set > the > whitespace correctly based on file type. > > https://github.com/editorconfig/editorconfig-visualstudio#readme > > Quoting sandra koroniewska (2017-05-05 12:01:02) > > Hi, > > thanks for your help and finding this information. I corrected the > offset > to 4 > > and changed these spaces to tab in VS. Is this patch all right now? > > > > Thanks, > > Sandra > > > > On Fri, May 5, 2017 at 8:55 PM, Sandra Koroniewska < > > [email protected]> wrote: > > > > This fixes > > tests/spec/gl-3.1/genned-names on Windows Intel driver. According to > OpenGL > > 4.5 Spec page 81, offset is restricted to be a multiple of 4 for > transform > > feedback bindings. > > --- > > tests/spec/gl-3.1/genned-names.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/spec/gl-3.1/genned-names.c b/tests/spec/gl-3.1/ > genned- > > names.c > > index bc75ae4d6..f484997b0 100644 > > --- a/tests/spec/gl-3.1/genned-names.c > > +++ b/tests/spec/gl-3.1/genned-names.c > > @@ -157,7 +157,7 @@ test_bindbuffer_tfb() > > glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 600); > > pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass; > > > > - glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, > 1); > > + glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, > 4); > > pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass; > > > > return pass; > > -- > > 2.11.0.windows.1 > > > > > > > >
signature.asc
Description: signature
_______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
